fix(UnifiedSearch): request data only when opening modal #50241
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
approved these changes
Jan 17, 2025
Antreesy
force-pushed
the
perf/noid/unified-search-init
branch
from
e8171b3 to
ebb170f
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
perf/noid/unified-search-init
branch
from
5bca14e to
627b342
Compare
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
susnux
reviewed
Jan 17, 2025
Comment on lines
+320
to
+322
| .catch(error => { | ||
| console.error(error) | ||
| }) |
There was a problem hiding this comment.
Suggested change
| .catch(error => { | |
| console.error(error) | |
| }) | |
| .catch((error) => { | |
| unifiedSearchLogger.error(error) | |
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two requests are always being made on page opening/reload, even though search modal wasn't yet opened once (and there's no guarantee a user would use it until next page reload). So data should be fetched only when modal is actually opened
Checklist