-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide "Create templates folder" option if templates are disabled #50215
Conversation
…nfiguration When both `skeletondirectory` and `templatedirectory` are set to empty strings in configuration, templates folder creation should be disabled and no Create templates folder option should be present in new folder menu. Related: nextcloud#39266 Related: nextcloud#46455 Author-Change-Id: IB#1156403 Signed-off-by: Pawel Boguslawski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, I think the change makes sense, only eslint needs a small adjustment
Also just a small thing, we went for the generic license header recently, so contributor attributions should go into the AUTHORS.md file, see https://docs.nextcloud.com/server/latest/developer_manual/getting_started/coding_standards/index.html#license-headers for details. |
License header removed. Linting fixed. |
perfect, thanks @pboguslawski 🙏 - Looks good to me 👍 By the way, you are a member of the Nextcloud Github organization, so you can also create branches and PRs on this repository. That way all Github actions will get executed. Just mentioning it since several actions are disabled on forks for security reasons. |
@pboguslawski I pushed your changes to #50464 so all CI checks can run and close this PR in favor of the local one 👍 |
Summary
When both
skeletondirectory
andtemplatedirectory
are set to empty strings in configuration, templates folder creation should be disabled and no Create templates folder option should be present in new folder menu.Related: #39266
Related: #46455
Author-Change-Id: IB#1156403
Checklist