Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): hide move dialog action if destination has no CREATE permission #50177

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Antreesy
Copy link
Contributor

Summary

'MOVE' action requires both 'CREATE'+'DELETE' permission, therefore it should be hidden for non-writable directories. Currently action fails.

Before After
image image

Alternative: disable button (with the same logic)

Checklist

@Antreesy Antreesy added this to the Nextcloud 31 milestone Jan 14, 2025
@Antreesy Antreesy requested a review from susnux January 14, 2025 13:33
@Antreesy Antreesy self-assigned this Jan 14, 2025
@Antreesy Antreesy requested a review from skjnldsv as a code owner January 14, 2025 13:33
@Antreesy
Copy link
Contributor Author

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Jan 14, 2025

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

@skjnldsv skjnldsv mentioned this pull request Jan 14, 2025
@Antreesy
Copy link
Contributor Author

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

Still can't make it run locally, and don't want to waste CI resources for blind attempts 😔

@Antreesy
Copy link
Contributor Author

/compile /

@skjnldsv
Copy link
Member

skjnldsv commented Jan 15, 2025

Still can't make it run locally

How so?
It works out of the box on multiple machines here 🤔

@Antreesy Antreesy force-pushed the fix/45982/hide-move-action branch from ab6da71 to b06a876 Compare January 15, 2025 12:07
@Antreesy
Copy link
Contributor Author

/compile /

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2025

It works out of the box on multiple machines here

Need some tweaks to work on Windows + WSL2 + Docker + Cypress
normal dev setup has similar settings, but it's accessible due to proxy (ghcr.io/juliusknorr/nextcloud-dev-nginx:latest)

Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit a16abfb into master Jan 15, 2025
120 checks passed
@Antreesy Antreesy deleted the fix/45982/hide-move-action branch January 15, 2025 12:56
@skjnldsv
Copy link
Member

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

Please make sure tests are added as a followup @Antreesy 🙏

@Antreesy
Copy link
Contributor Author

/backport b06a876 to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants