-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): hide move dialog action if destination has no CREATE permission #50177
Conversation
/backport to stable30 |
Would it be possible to add a quick e2e test for this, so we do not run into regressions? |
Still can't make it run locally, and don't want to waste CI resources for blind attempts 😔 |
/compile / |
How so? |
…ission Signed-off-by: Maksim Sukharev <[email protected]>
ab6da71
to
b06a876
Compare
/compile / |
Need some tweaks to work on Windows + WSL2 + Docker + Cypress |
Signed-off-by: nextcloud-command <[email protected]>
Please make sure tests are added as a followup @Antreesy 🙏 |
/backport b06a876 to stable29 |
Summary
'MOVE' action requires both 'CREATE'+'DELETE' permission, therefore it should be hidden for non-writable directories. Currently action fails.
Alternative: disable button (with the same logic)
Checklist