-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): sort not working after changing views #50161
Conversation
/backport to stable30 |
/backport to stable29 |
446823a
to
1c3ec2a
Compare
b97a3d2
to
c966e04
Compare
// Init Navigation Service | ||
// This only works with Vue 2 - with Vue 3 this will not modify the source but return just a observer | ||
const Navigation = Vue.observable(getNavigation()) | ||
Vue.prototype.$navigation = Navigation | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
189daf0
to
18a670b
Compare
|
Signed-off-by: Richard Steinmetz <[email protected]>
18a670b
to
835994a
Compare
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50161/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 835994a8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50161/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Sorting the tabular view in files breaks if the view is changed twice.
How to reproduce?
Problem: The global
$navigation
object is not reactive enough and misses some changes.Before
2025-01-14.13-49-24.mp4
After
2025-01-14.13-51-11.mp4
TODO
Checklist