[stable29] fix(preview): Do not try to parse M3U files as MP3 #50080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
By default, the MP3 audio files get the mimetype `audio/mpeg` and the M3U and M3U8 playlist files get the mimetype `audio/mpegurl`. PreviewManager had such a problem that it registered the MP3 preview provider with a regular expression which matched also the M3U files. This caused an error message to be logged on the info (1) level for each M3U file every time a folder with such files was viewed: "Error while getting cover from mp3 file: File /path/to/some/playlist.m3u is not mpeg/audio!". Signed-off-by: Pauli Järvinen <[email protected]>
backportbot
bot
requested review from
nickvergessen,
provokateurin and
paulijar
provokateurin
approved these changes
Jan 7, 2025
AndyScherzinger
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #50051