-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemtags): add setting to block non admin to create system tags #49514
Open
Altahrim
wants to merge
3
commits into
master
Choose a base branch
from
feat/restrict-tag-creation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+281
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
force-pushed
the
feat/restrict-tag-creation
branch
4 times, most recently
from
November 28, 2024 12:36
d561ba1
to
7ed6833
Compare
Altahrim
force-pushed
the
feat/restrict-tag-creation
branch
from
December 9, 2024 09:23
7ed6833
to
c158e06
Compare
nfebe
force-pushed
the
feat/restrict-tag-creation
branch
3 times, most recently
from
December 20, 2024 12:04
8c7bd05
to
06bb2f1
Compare
nfebe
force-pushed
the
feat/restrict-tag-creation
branch
2 times, most recently
from
January 2, 2025 14:55
e27715d
to
d8d3c7e
Compare
nfebe
force-pushed
the
feat/restrict-tag-creation
branch
3 times, most recently
from
January 13, 2025 14:12
5b049ce
to
5cf90d5
Compare
nfebe
force-pushed
the
feat/restrict-tag-creation
branch
from
January 13, 2025 14:51
5cf90d5
to
f7e6dc9
Compare
nfebe
requested review from
artonge,
skjnldsv,
Pytal,
provokateurin and
come-nc
January 13, 2025 14:54
sorbaugh
approved these changes
Jan 13, 2025
provokateurin
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor things, LGTM
Altahrim
force-pushed
the
feat/restrict-tag-creation
branch
from
January 14, 2025 08:52
f7e6dc9
to
001ec5a
Compare
provokateurin
approved these changes
Jan 14, 2025
skjnldsv
requested changes
Jan 14, 2025
Merged
nfebe
force-pushed
the
feat/restrict-tag-creation
branch
from
January 16, 2025 11:24
0767e7b
to
27b128d
Compare
/compile |
skjnldsv
approved these changes
Jan 16, 2025
Merged
Altahrim
force-pushed
the
feat/restrict-tag-creation
branch
from
January 17, 2025 14:16
d99256f
to
69f8d5e
Compare
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: nfebe <[email protected]>
Added support for the `only_admin_can_create` flag in system tags. The UI now hides the option to create tags when this flag is enabled, ensuring compliance with admin settings. Signed-off-by: nfebe <[email protected]>
Altahrim
force-pushed
the
feat/restrict-tag-creation
branch
from
January 17, 2025 14:43
69f8d5e
to
76ad5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows admins to restrict tag creation to admins only
Switch with:
TODO
Checklist