Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add eol in dav command and use success const as return code #48800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GreyXor
Copy link

@GreyXor GreyXor commented Oct 19, 2024

  • Resolves: Each CLI commands should return a end-of-line after execution

Summary

TODO

  • ...

Checklist

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@GreyXor
Copy link
Author

GreyXor commented Jan 13, 2025

@come-nc Hello, would you mind review my PR ? Thanks !

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self::FAILURE should be used instead of return 1 for consistency.

@GreyXor
Copy link
Author

GreyXor commented Jan 16, 2025

Thanks and done 👍
@come-nc Can you tell me if I should mention someone else for a review and a merge ?

@come-nc
Copy link
Contributor

come-nc commented Jan 16, 2025

@GreyXor Can you have a look at https://github.com/nextcloud/server/pull/48800/checks?check_run_id=35620554716 and see if you can fix DCO? The idea is to use git commit --signoff (or -s).
In your situation you can use git rebase commant with --signoff option to edit existing commit before force push.
You can also rebase on master to avoid the merge commits.

@come-nc come-nc requested a review from artonge January 16, 2025 15:34
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 16, 2025
@come-nc come-nc added this to the Nextcloud 31 milestone Jan 16, 2025
@skjnldsv skjnldsv mentioned this pull request Jan 16, 2025
@GreyXor
Copy link
Author

GreyXor commented Jan 16, 2025

@GreyXor Can you have a look at https://github.com/nextcloud/server/pull/48800/checks?check_run_id=35620554716 and see if you can fix DCO? The idea is to use git commit --signoff (or -s). In your situation you can use git rebase commant with --signoff option to edit existing commit before force push. You can also rebase on master to avoid the merge commits.

Thanks, I signed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants