-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add eol in dav command and use success const as return code #48800
base: master
Are you sure you want to change the base?
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@come-nc Hello, would you mind review my PR ? Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self::FAILURE should be used instead of return 1 for consistency.
Thanks and done 👍 |
@GreyXor Can you have a look at https://github.com/nextcloud/server/pull/48800/checks?check_run_id=35620554716 and see if you can fix DCO? The idea is to use git commit --signoff (or -s). |
Signed-off-by: GreyXor <[email protected]>
Signed-off-by: GreyXor <[email protected]>
Thanks, I signed it |
Summary
TODO
Checklist