Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): Remove very verbose dirty query logs #42922

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(db): Remove very verbose dirty query logs #42922

merged 1 commit into from
Jan 18, 2024

Conversation

ChristophWurst
Copy link
Member

Summary

  • Primary/secondary switching happens in almost every request. Logging this is too much. If one is interested in this mechanism they can turn on query logging. Query logs are prefixed with primary/replica.
  • Logging dirty tables for each statement (write) is a lot. This doesn't have a real benefit. Removing.

Checklist

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Jan 18, 2024
@ChristophWurst ChristophWurst self-assigned this Jan 18, 2024
@blizzz

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 18, 2024
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@blizzz

This comment was marked as resolved.

Sign in to view
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 18, 2024
@miaulalala miaulalala force-pushed the fix/db/no-verbose-dirty-query-logs branch from 3a33966 to ab0d7c0 Compare January 18, 2024 17:33
@ChristophWurst ChristophWurst merged commit 3d51213 into master Jan 18, 2024
50 checks passed
@ChristophWurst ChristophWurst deleted the fix/db/no-verbose-dirty-query-logs branch January 18, 2024 18:58
@ChristophWurst ChristophWurst mentioned this pull request Feb 23, 2024
Closed
10 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@provokateurin provokateurin provokateurin approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @blizzz @juliusknorr @provokateurin @come-nc @nickvergessen