Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Provides toolbar for native markdown editor #2209

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefan-niedermann
Copy link
Member

Currently the toolbar is positioned below the content so

  • the actions are reachable more ergonomically and
  • the additional vertical gap when switching between preview and edit mode can be avoided
    However, the collaborative rich editor shows its menu bar above the content.

Which way should we go? Consistency vs. ergonomics? Or would you even consider to switch the toolbar position for the collaborative rich editor?

CC @tobiasKaminsky @AndyScherzinger

_ _
Screenshot_20240523_113405 Screenshot_20240523_114309

Please note that the toolbar integration might still have some bugs left which would need to be addressed in the stefan-niedermann:nextcloud-commons library.

@AndyScherzinger
Copy link
Member

Hmmm, good question.

I checked the notes apps of Google and OnePlus and both have the editor bar at the bottom.

@nextcloud/designers what do you think?

@marcoambrosini
Copy link
Member

Great addition :)
Out of these two I would prefer the bar at the bottom.

However, I would favor a floating toolbar that is not shown at all times, but only when text is selected and an editing operation is likely to occur.

As an example, this is the toolbar that pops up in signal when text is selected.

Screenshot_20240527-091645

@stefan-niedermann
Copy link
Member Author

However, I would favor a floating toolbar that is not shown at all times, but only when text is selected and an editing operation is likely to occur.

This describes exactly the same behavior as today (see FAQ) and it will continue to work. However there are some drawbacks:

  1. This behavior has never been fully accepted by the users. A quick search in the issue section will show you dozens of requests to always have buttons present
  2. This behavior is not supported by Nextcloud Text and therefore would contradict the efforts to minimize the inconsistences between the two edit modes of the Notes Android app as well as the inconsistences of Notes Android compared to Notes server

@marcoambrosini
Copy link
Member

  1. I think it might be a vocal minority of users. For the purpose of taking notes on mobile I think it's perfectly fine if text style is not always visible.
  2. I don't think we should aim at "consistency at all costs" on different platforms. I would favour displaying more of the content of the note on small screens over the pursuit of consistency in this case. Also, on this point I'd very much like to see this "edit on select" behaviour coming on the text app on the web. It's just overall more intuitive and requires less jumping around with the mouse.

That said, if you really think we need this, I vote for edit bar just above the keyboard :)

@stefan-niedermann
Copy link
Member Author

I don't think we should aim at "consistency at all costs" on different platforms

It's about consistency within the app itself. The Notes Android app ships two editors which can be toggled in the Notes Android apps settings, both with pros and cons.

Also, on this point I'd very much like to see this "edit on select" behaviour coming on the text app on the web

This has been declined in nextcloud/notes#200 (comment)

Additional context: A similar issue exists for the Notes server app (which also ships two editors).

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice @stefan-niedermann! :) I would say editor bar at the bottom is good, since also as @AndyScherzinger said others do this.

And yes, they should be permanent for the reasons you mention, also as other apps have this too. (Also e.g. Notes on iOS.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ At engineering
Development

Successfully merging this pull request may close these issues.

4 participants