fix: remove unused options for non existing compact mode

add changelog entry Signed-off-by: Wolfgang <[email protected]> Signed-off-by: Benjamin Brahmer <[email protected]>
nextcloud · Oct 14, 2024 · 52209e3 · 52209e3
1 parent 4df9951
commit 52209e3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the
 - Unread counter does not count down when folders or feeds are marked read (#2800)
 - Query fetching status didn't work (#2800)
 - Keyboard shortcuts are active even when searching (#2738)
-
+- First features for user settings after vue migration (#2795)
 
 # Releases
 ## [25.0.0-alpha9] - 2024-10-03

diff --git a/lib/Controller/PageController.php b/lib/Controller/PageController.php
@@ -18,7 +18,6 @@
 use OCP\IRequest;
 use OCP\IAppConfig;
 use OCP\Util;
-use OCP\IConfig;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\AppFramework\Http\TemplateResponse;
@@ -36,7 +35,7 @@ class PageController extends Controller
     use JSONHttpErrorTrait;
 
     /**
-     * @var IConfig
+     * @var IAppConfig
      */
     private $settings;
 
@@ -67,7 +66,7 @@ class PageController extends Controller
 
     public function __construct(
         IRequest $request,
-        IConfig $settings,
+        IAppConfig $settings,
         IURLGenerator $urlGenerator,
         IL10N $l10n,
         RecommendedSites $recommendedSites,

diff --git a/src/components/Sidebar.vue b/src/components/Sidebar.vue
@@ -130,26 +130,6 @@
 							{{ t('news', 'Disable mark read through scrolling') }}
 						</label>
 					</div>
-					<!---
-					<div>
-						<input id="toggle-compact"
-							v-model="compact"
-							type="checkbox"
-							class="checkbox">
-						<label for="toggle-compact">
-							{{ t('news', 'Compact view') }}
-						</label>
-					</div>
-					<div>
-						<input id="toggle-compactexpand"
-							v-model="compactExpand"
-							type="checkbox"
-							class="checkbox">
-						<label for="toggle-compactexpand">
-							{{ t('news', 'Expand articles on key navigation') }}
-						</label>
-					</div>
-					--->
 					<div>
 						<input id="toggle-showall"
 							v-model="showAll"