Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for NC26+ and PHP 8.0 #78

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Aug 3, 2023

Content

  • Add some tests/helpers (psalm, cs-fixer, phpunit)
  • Upgrade for PHP 8.0 and Nextcloud 26+
  • Fix display problem on forbidden page
  • Fix bug with login on URL like /index.php/login?redirect_url=/index.php/settings/admin/security

@Altahrim Altahrim self-assigned this Aug 3, 2023
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch 20 times, most recently from be96362 to b6573cf Compare August 4, 2023 14:50
@Altahrim Altahrim marked this pull request as ready for review August 4, 2023 14:56
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch 6 times, most recently from 59b6c6f to 0f009fd Compare August 7, 2023 13:59
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch from 0f009fd to acd1670 Compare August 7, 2023 14:28
Copy link

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer $var === null over null === $var but otherwise it looks good.

tests/integration/features/Login.feature Outdated Show resolved Hide resolved
appinfo/info.xml Outdated Show resolved Hide resolved
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch 2 times, most recently from 26c3856 to 39e4067 Compare August 8, 2023 07:16
Uses `mlocati/ip-lib` for IP check

Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch 7 times, most recently from c42dadd to 91eebe6 Compare August 8, 2023 08:09
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim force-pushed the feat/support-nc26-php8-with-iplib branch from 91eebe6 to 97ce05f Compare August 8, 2023 08:15
lib/LoginHookListener.php Show resolved Hide resolved
@Altahrim Altahrim merged commit fb76d36 into master Aug 8, 2023
7 checks passed
@Altahrim Altahrim deleted the feat/support-nc26-php8-with-iplib branch August 8, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants