#3169 fix ssl client certificate #3223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Fischer <[email protected]>
Signed-off-by: Patrick Fischer <[email protected]>
Signed-off-by: Patrick Fischer <[email protected]>
zero0cool0
changed the title
|
@zero0cool0 thanks ! @mpivchev can you check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3169
I tested SSL Client Certificate authentication and found that it didn't really work for me.
NCLogindoes not set itself ascertificateDelegateofNCNetworkinghence its delegate methods are never called if NSURLAuthenticationMethodClientCertificate is received inNCNetworking.authenticationChallenge didReceive challengeUIAlertControllers in
NCLoginare not presented on the main threadThese two changes correctly prompt for a certificate file to pick and also ask for a certificate password.
However, once the login flow is restarted after
p12Datais set,authenticationChallenge didReceive challengewasn't called once more, I suspect due to a reuse of the underlying SSL session.I found that instead of the default action, it is better to cancel the authentication challenge if
didAskForClientCertificate()is called on the delegate. This leads to the challenge being received and now properly answered with the client certificate.