-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nginx): add option to easy manage HEADERS (make it possible to set HSTS) #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrenix
force-pushed
the
fix/hsts-on-nginx
branch
2 times, most recently
from
September 19, 2024 18:05
51f27a8
to
8d5e6e7
Compare
provokateurin
previously requested changes
Sep 19, 2024
jessebot
reviewed
Sep 20, 2024
jessebot
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also update the README.md?
i move all headers to |
wrenix
force-pushed
the
fix/hsts-on-nginx
branch
2 times, most recently
from
September 21, 2024 10:11
f4396a1
to
e6c8079
Compare
jessebot
reviewed
Sep 24, 2024
wrenix
force-pushed
the
fix/hsts-on-nginx
branch
from
October 11, 2024 22:10
e6c8079
to
02a58b8
Compare
ping @jessebot |
jessebot
reviewed
Oct 21, 2024
wrenix
changed the title
fix(nginx): add option to easy set HSTS
fix(nginx): add option to easy manage HEADERS (make it possible to set HSTS)
Oct 22, 2024
wrenix
force-pushed
the
fix/hsts-on-nginx
branch
from
October 22, 2024 08:26
02a58b8
to
5e8b9b5
Compare
…t HSTS) Signed-off-by: WrenIX <[email protected]>
wrenix
force-pushed
the
fix/hsts-on-nginx
branch
from
October 22, 2024 08:29
5e8b9b5
to
06726fe
Compare
jessebot
approved these changes
Oct 22, 2024
@wrenix looks good to me, feel free to merge :) |
jessebot
dismissed
provokateurin’s stale review
October 22, 2024 09:19
this has been addressed and fixed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.