adopt netxcloud.containerport in FPM deployment, allow rootless nginx #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poggenpower
changed the title
jessebot
reviewed
Sep 3, 2023
jessebot
reviewed
Sep 3, 2023
jessebot
previously requested changes
Sep 3, 2023
jessebot
reviewed
Sep 4, 2023
jessebot
reviewed
Sep 4, 2023
poggenpower
force-pushed
the
main
branch
2 times, most recently
from
812b589
to
05b75ef
Compare
jessebot
dismissed
their stale review
all changes requested were done, but don't want to approve till workflows have run
|
@poggenpower sorry, it says there's a conflict even though there's not. Can you fix the conflict? I don't want to update your main branch unless you're ok with that. |
is netxcloud.containerport is set, it will also configure the port for nginx. This allows nginx running in a rootless container e.g. by using their official `nginxinc/nginx-unprivileged` image. pid is written to /tmp for that reason. Some enhanced configs parameter for service. Signed-off-by: poggenpower <[email protected]>
Signed-off-by: poggenpower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
is
netxcloud.containerportis set, it will also configure the port for nginx. This allows nginx running in a rootless container e.g. by using their officialnginxinc/nginx-unprivilegedimage. pid is written to /tmp for that reason.Some enhanced configs parameter for service.
Benefits
rootless nginx conaiiner.
Possible drawbacks
the nginx port will switch to
netxcloud.containerportin FPM installations, but this should benetxcloud.containerportshould not be changedApplicable issues
N/A
Additional information
Checklist
Chart.yamlaccording to semver.