Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not define loadBalancerIP on service unless set in values #430

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Do not define loadBalancerIP on service unless set in values #430

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
907b697
Update Chart.yaml
benyanke Aug 18, 2023
184ea1d
Update README.md
benyanke Aug 18, 2023
841ccf3
Update service.yaml
benyanke Aug 18, 2023
6ce3c64
Update values.yaml
benyanke Aug 18, 2023
697c092
Merge branch 'main' into issue-428-b
jessebot Aug 19, 2023
2aa5976
Bump version
benyanke Aug 23, 2023
54d25fb
Set to empty string instead of omitting value key
benyanke Aug 23, 2023
491ba29
Update charts/nextcloud/README.md
benyanke Aug 23, 2023
e34ec69
Update charts/nextcloud/README.md - fix markdown chart formatting
jessebot Aug 23, 2023
a6f537b
Update charts/nextcloud/README.md - fix markdown formatting again
jessebot Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 4.0.0
version: 4.1.0
appVersion: 27.0.2
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/nextcloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ The following table lists the configurable parameters of the nextcloud chart and
| `cronjob.resources` | CPU/Memory resource requests/limits for the cronjob sidecar | `{}` |
| `cronjob.securityContext` | Optional security context for cronjob | `nil` |
| `service.type` | Kubernetes Service type | `ClusterIP` |
| `service.loadBalancerIP` | LoadBalancerIp for service type LoadBalancer | `nil` |
| `service.loadBalancerIP` | LoadBalancerIp for service type LoadBalancer | `""` |
jessebot marked this conversation as resolved.
Show resolved Hide resolved
jessebot marked this conversation as resolved.
Show resolved Hide resolved
| `service.nodePort` | NodePort for service type NodePort | `nil` |
| `phpClientHttpsFix.enabled` | Sets OVERWRITEPROTOCOL for https ingress redirect | `false` |
| `phpClientHttpsFix.protocol` | Sets OVERWRITEPROTOCOL for https ingress redirect | `https` |
Expand Down
2 changes: 1 addition & 1 deletion charts/nextcloud/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
app.kubernetes.io/component: app
spec:
type: {{ .Values.service.type }}
{{- if eq .Values.service.type "LoadBalancer" }}
{{- if and (eq .Values.service.type "LoadBalancer") .Values.service.loadBalancerIP }}
loadBalancerIP: {{ default "" .Values.service.loadBalancerIP }}
{{- end }}
ports:
Expand Down
2 changes: 1 addition & 1 deletion charts/nextcloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ cronjob:
service:
type: ClusterIP
port: 8080
loadBalancerIP: nil
loadBalancerIP: ""
nodePort: nil

## Enable persistence using Persistent Volume Claims
Expand Down