fix(editor): Position outline in the margin left of editor #1615
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
Dec 18, 2024
max-nextcloud
approved these changes
Dec 19, 2024
Fixes: #1614 Signed-off-by: Jonas <[email protected]>
This works around a race condition and is not the perfect solution, but it fixes a long-standing flaky test. Signed-off-by: Jonas <[email protected]>
Apparently there's a race condition that results in the edit mode not being activated when creating a page from template in Cypress. This happens in the majority of runs of this test. I was never able to manually reproduce this problem. Instead of living with a mostly failing test, let's disable the check for edit mode for now. This way we at least have a test for using the template page again and hopefully a green CI. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/outline_position
branch
from
0f4b9da to
a288018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1614
🖼️ Screencast
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)