-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public page shares #1041
Public page shares #1041
Conversation
Passing run #1318 ↗︎
Details:
Review all test suite changes for PR #1041 ↗︎ |
dd35114
to
d7d8426
Compare
This is about sharing pages that don't have a subpage yet. Unfortunately it's not so easy given that right now pages without a subpage are single markdown files (e.g. I think we should just do the following:
This is a first step in migrating away from the mix of What do you think @max-nextcloud? |
d7d8426
to
d771d1f
Compare
@mejo- sounds like a good approach to me.
I thought they'd always live in a |
d771d1f
to
29d28d9
Compare
Exactly 😉 |
Super nice improvement! It looks great, only 2 small changes:
This is maybe a bigger discussion, but I wonder if it makes sense to combine the "Manage members" and "Manage sharing" to some degree. Both of those things are regarding who has access to the collective/page. This could be as simple as showing the members of the collective in the sharing tab as a "People with access" section (similar to the "Others with access" in the Files sharing) where there is also a button to "Manage members". But that's definitely a follow-up topic :) |
* Hide list of collectives * Show root page emoji+title instead of collective emoji+name Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
We no longer change `page/Readme.md` back to `page.md` if `page` becomes a leaf page (i.e. without children). In the long term we want to move to the `page/Readme.md` format everywhere. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Fixes opening shares if there's more than one for a collective. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
71d234a
to
0916700
Compare
Fixes: #633 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
0916700
to
e5c2985
Compare
hi, |
Second that question: The mockups in OP show a nice single page sharing dialogue, but it appears absent in the version shipped with NC 28 |
📝 Summary
🖼️ Screenshots
🚧 TODO
checkPagePermissions()
in PublicPageController🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)