Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dasbhoard): Respect item limit #1020

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(dasbhoard): Respect item limit #1020

merged 1 commit into from
Nov 17, 2023

Conversation

provokateurin
Copy link
Member

📝 Summary

The widget didn't respect the limit. This limit can be specified in the dashboard API so it is important to follow it.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@provokateurin provokateurin added bug Something isn't working 3. to review labels Nov 17, 2023
@provokateurin provokateurin mentioned this pull request Nov 17, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Nov 17, 2023

Where do you even configure that value?

@provokateurin
Copy link
Member Author

https://github.com/nextcloud/server/blob/158aedb549b253b0b8a84a7c68c0d7bca9e7be54/apps/dashboard/lib/Controller/DashboardApiController.php#L110

@blizzz
Copy link
Member

blizzz commented Nov 17, 2023

https://github.com/nextcloud/server/blob/158aedb549b253b0b8a84a7c68c0d7bca9e7be54/apps/dashboard/lib/Controller/DashboardApiController.php#L110

I mean, as a user 😃

@blizzz blizzz merged commit 44a400e into main Nov 17, 2023
48 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/dashboard/limit branch November 17, 2023 08:28
@provokateurin
Copy link
Member Author

I don't think it is configurable at all. I think all clients just use the default value of 7 🤷‍♀️

@blizzz
Copy link
Member

blizzz commented Nov 17, 2023

https://github.com/nextcloud/server/blob/158aedb549b253b0b8a84a7c68c0d7bca9e7be54/apps/dashboard/lib/Controller/DashboardApiController.php#L110

btw, it could sanitize a reasonable limit range check 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @blizzz