fix(NewCollectiveModal): Mention that own user is part of collective #1003
Conversation
| @@ -87,6 +87,7 @@ | |||
| <MemberPicker :show-selection="true" | |||
| :selected-members="selectedMembers" | |||
| :on-click-searched="onClickSearched" | |||
| :empty-content-hint="t('collectives', 'Your user is added automatically.')" | |||
There was a problem hiding this comment.
Not sure about the wording. Maybe "As creator, you're already added." is better? 🤔
There was a problem hiding this comment.
Instead of as a message, we could show the owner's account directly below in the list like added accounts do? That would make it more obvious than a line of text.
Slightly related: We want to move from the wording "user" to either "account" or "person", could be replaced in the search field.
1 flaky test on run #1270 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Page > Editing a page > Lists attachments for the page and allows restore |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1003 ↗︎
|
Thanks @jancborchardt, much better. Implemented now, see the screencast above. I also changed "users" to "accounts" where appropriate. |
mejo-
force-pushed
the
fix/create_collective_hint
branch
2 times, most recently
from
88757c7 to
6b4b1ed
Compare
|
I wonder whether it would further help to change the "Create" button to something like "Create without adding people" in case no other members were selected. |
|
Small addition, we could preserve the previously entered collective name in the dialog title to make it more obvious what this is about, e.g. "Add people to fox" instead of just "Add people". Overall i find the different usages of account/people/members a bit confusing. 
Maybe we can somehow unify that? Pick one high level word (members) and a fixed set for the actual membership entities (account, group, circle)? |
I agree, thanks for bringing this up. Your suggestion makes sense: account, group, circle for the different entities and "members" for all of them. So I'd replace "Add people" with "Add members" and search for more occurrences of "users" to be replaced by "accounts". Agreed? |
mejo-
force-pushed
the
fix/create_collective_hint
branch
from
6b4b1ed to
a098f0b
Compare
People got confused by searching their own user. Signed-off-by: Jonas <[email protected]>
…ers" * Mention collective name in title: "Add members to <name>". * Change "Create" button to "Create without members" if no members are picked. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/create_collective_hint
branch
from
a098f0b to
bafc785
Compare
Great idea. Implemented now (using "Add members to "). See updated screencast above.
Also implemented. See updated screencast above. |
People got confused by searching their own user.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)