Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some imaginary dependencies to improve performance #2114

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Mar 6, 2023

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Mar 6, 2023
@szaimen szaimen added this to the next milestone Mar 6, 2023
@szaimen szaimen marked this pull request as ready for review March 7, 2023 08:42
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 7, 2023
@szaimen szaimen requested a review from Zoey2936 March 7, 2023 08:42
@Zoey2936
Copy link
Collaborator

Zoey2936 commented Mar 7, 2023

why sid? sid is called experimental currently for reasons

@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

why sid? sid is called experimental currently for reasons

It was recommended in nextcloud/server#35643 (comment). Do you think we should rather go with backports instead or not do this at all?

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Mar 7, 2023

would bookworm maybe be the better way? and would it not be better to add the packages list only for installing the packages and then removing them?

@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

would bookworm maybe be the better way?

Sounds good!

and would it not be better to add the packages list only for installing the packages and then removing them?

wdym?

Signed-off-by: Simon L <[email protected]>
@Zoey2936
Copy link
Collaborator

Zoey2936 commented Mar 7, 2023

and would it not be better to add the packages list only for installing the packages and then removing them?

wdym?

deleting the /etc/apt/sources.list.d/bookworm.list file after installing and adding it first after installing the netcat package

Signed-off-by: Simon L <[email protected]>
@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

deleting the /etc/apt/sources.list.d/bookworm.list file after installing and adding it first after installing the netcat package

good point, done👍

@szaimen szaimen requested review from Zoey2936 and removed request for Zoey2936 March 7, 2023 09:21
@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

Thanks Zoey! :)

@szaimen szaimen merged commit 07054d8 into main Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/update-imaginary-dependencies branch March 7, 2023 09:23
@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

@Zoey2936 this seems to fail: https://github.com/nextcloud-releases/all-in-one/actions/runs/4352742007/jobs/7605899041

Do you have any idea what is wrong and how to fix this?

@szaimen
Copy link
Collaborator Author

szaimen commented Mar 7, 2023

Found it: 671a73a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants