Merge pull request #3214 from nextcloud/enh/noid/add-stop-grace-perio…

…d-nextcloud nextcloud - add stop_grace_period of 600s and wait for cron to finish during that time
nextcloud · Dec 1, 2023 · 890ba86 · 890ba86
2 parents 173b3e2 + 14e8996
commit 890ba86
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Containers/nextcloud/cron.sh b/Containers/nextcloud/cron.sh
@@ -1,7 +1,20 @@
 #!/bin/bash
 set -eu
 
+wait_for_cron() {
+    set -x
+    while [ -n "$(pgrep -f /var/www/html/cron.php)" ]; do
+        echo "Waiting for cron to stop..."
+        sleep 5
+    done
+    echo "Cronjob successfully exited."
+    set +x
+}
+
+trap wait_for_cron SIGINT SIGTERM
+
 while true; do
     php -f /var/www/html/cron.php &
-    sleep 5m
+    sleep 5m &
+    wait $!
 done
diff --git a/php/containers.json b/php/containers.json
@@ -215,6 +215,7 @@
         "APACHE_IP_BINDING=%APACHE_IP_BINDING%",
         "THIS_IS_AIO=true"
       ],
+      "stop_grace_period": 600,
       "restart": "unless-stopped",
       "devices": [
         "/dev/dri"