chart: add -scraper suffix to pod names

[nadiamoe]

As previously discussed, the overly simplified names were causing some confusion among users. The -scraper suffix should hopefully help to make more obvious that these pods are clients, rather than servers.

[kang-makes]

Take a look at the container's name because this is a cool opportunity to change that too.

[kang-makes]

NIT: I would prefer kubelet-node-scraper because the v2 of this integration named these pods as node.

Suggested change

	{{- include "newrelic.common.naming.truncateToDNSWithSuffix" (dict "name" (include "nriKubernetes.naming.fullname" .) "suffix" "ksm-agent") -}}
	{{- include "newrelic.common.naming.truncateToDNSWithSuffix" (dict "name" (include "nriKubernetes.naming.fullname" .) "suffix" "kubelet-node-scraper") -}}

[kang-makes]

Solves #420

[nadiamoe]

Pods with the new name look fine and deploy like this:

(Note the 3 in newr3lic is intentional as helm does not allow to have two releases with the same name in the same cluster)

[gsanchezgavier]

LGTM

[paologallinaharbur]

@roobre can we merge this?

[nadiamoe]

@paologallinaharbur Virtuoso is making tests with their updated recipe right now, I'll merge if they confirm everything works as expected :)

[htroisi]

The ksm pod naming also confused me. @roobre I think PR is a great idea!

[htroisi]

Chatted with @roobre and the status of this PR is that it was blocked by the new virtuoso (guided install cli) recipe. The recipe has a “success check” that, after running helm install, checks for the existence of certain pods to verify the installation. And so we may need to coordinate the updating of these pod names there.