feat: PHP 8.4 #996

ZNeumann · 2024-12-12T19:05:01Z

Adds 8.4 to builds/tests/installers. Requires some updates to our make/configure scripts to adapt to changes in PHP autoconf macros.

Bumps monolog and guzzle versions for 8.4 support from those libraries.

Adjusts tests to account for new closure naming in PHP 8.4

Adjusts tests to account for deprecation of E_USER_ERROR

newrelic-php-agent-bot · 2024-12-12T19:05:29Z

Test Suite	Status	Result
Multiverse	✅	7/7 passing
SOAK	✅	62/62 passing

codecov-commenter · 2024-12-12T19:28:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (0d0f724) to head (654f61b).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #996      +/-   ##
==========================================
+ Coverage   77.94%   78.04%   +0.09%     
==========================================
  Files         195      196       +1     
  Lines       26325    27104     +779     
==========================================
+ Hits        20520    21154     +634     
- Misses       5805     5950     +145

Flag	Coverage Δ
agent-for-php-7.2	`78.03% <ø> (?)`
agent-for-php-7.3	`78.05% <ø> (?)`
agent-for-php-7.4	`77.76% <ø> (?)`
agent-for-php-8.0	`77.13% <ø> (?)`
agent-for-php-8.1	`77.79% <ø> (?)`
agent-for-php-8.2	`?`
agent-for-php-8.3	`77.38% <ø> (?)`
agent-for-php-8.4	`77.40% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…e, file, and line

lavarou

LGTM

agent/config.m4

agent/tests/test_agent.c

tests/integration/api/error_group_callback/test_error_group_callback_error_web.php84.php

`ZEND_MODULE_API_NO` for PHP 8.4 is actually `20240924`.

PHP's build system received a fix for 'out of tree' builds. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that `test_function_debug_name` needed its expectations tweaked - closures are named differently on PHP 8.4.

PHP 8.4 includes implementation of PDO driver specific sub-classes RFC (see https://wiki.php.net/rfc/pdo_driver_specific_subclasses). This means that when database access code uses new factory method `PDO::connect` to create PDO object, an instance of driver specific sub-class of `PDO` is returned instead of an instance of generic `PDO` class. This means that instrumentation of generic `PDO` class is not enough to provide instrumentation of datastores. Add wrappers for driver specific subclasses of `PDO` supported by the agent: `Pdo\Firebird`, `Pdo\Mysql`, `Pdo\Odbc`, `Pdo\Pgsql`, `Pdo\Sqlite`.

zsistla

looks good, thanks!

sidneyprins · 2025-01-08T13:52:40Z

docs/development.md

@@ -58,7 +58,7 @@ _(most operating systems package these with `-dev` or `-devel` suffixes)_

 ### PHP

-The PHP agent supports PHP versions `7.2`, `7.3`, `7.4`,`8.0`, `8.1`, '8.2', and `8.3`.
+The PHP agent supports PHP versions `7.2`, `7.3`, `7.4`,`8.0`, `8.1`, '8.2', `8.3` and `8.4`.


'8.2' -> 8.2

fixed in 654f61b

sidneyprins · 2025-01-08T13:53:54Z

tests/integration/api/notice_error/test_good_4_args_error_handler.php

@@ -142,8 +142,8 @@
 */

 function a() {
-    trigger_error("4 arg error", E_USER_ERROR);
+    trigger_error("4 arg error", E_USER_WARNING);


A warning is not an error?

This comment is for all occurences where E_USER_ERROR is changed to E_USER_WARNING

E_USER_ERROR was deprecated in PHP 8.4. However, using E_USER_WARNING with trigger_error fulfills the same role for our purposes here and elsewhere in these tests.

PHP (or at the very least our configuration of PHP) itself is treating this as an error, calling any error handler set with set_error_handler. Thus, the agent also treats this as an error, recording the appropriate information. The differences in behavior, however, are 2-fold. 1) E_USER_WARNING is not deprecated, resulting in no additional warnings. and 2) E_USER_WARNING does not trigger a bailout, which some tests have been split into a pre/post 8.4 version to account for.

sidneyprins · 2025-01-08T13:54:53Z

tests/integration/api/notice_error/test_priority.php

 trigger_error ("lowest priority", E_USER_NOTICE);
+trigger_error ("goldilox", E_USER_DEPRECATED);
+trigger_error ("highest priority", E_USER_WARNING);
+trigger_error ("goldilox", E_USER_DEPRECATED);


The warnings have been changed?

E_USER_ERROR was deprecated, so these triggered errors were changed while maintaining their relative statuses. Previously, this test wasn't even fully doing what it intended to though, because E_USER_ERROR triggers a bailout and prevents the execution of further code. For the purposes of this test, because E_USER_ERROR is also the highest priority, that was resulting in tested behavior that would be indistinguishable from the agent just keeping the most recent error.

lavarou

LGTM

ZNeumann marked this pull request as ready for review December 12, 2024 19:58

ZNeumann linked an issue Dec 12, 2024 that may be closed by this pull request

PHP 8.4 #909

Open

ZNeumann mentioned this pull request Dec 12, 2024

Added PHP 8.4 scaffold support #980

Closed

zsistla added this to the PHP 8.4 support milestone Dec 16, 2024

lavarou force-pushed the php84 branch from c983906 to e3e6870 Compare December 16, 2024 14:37

zsistla force-pushed the php84 branch from e3e6870 to 423e822 Compare December 20, 2024 19:48

willitscale and others added 5 commits December 20, 2024 18:06

Added PHP 8.4 scaffold support

467b75c

Updated version of Zend Module API NO

2a16db5

update autoconf macro call

f9d180a

fix(integration): PHP 8.4 Closure::__debugInfo() now includes the nam…

ed401d7

…e, file, and line

fix(integration): no longer use E_USER_ERROR

26146a5

lavarou force-pushed the php84 branch from 423e822 to d5cf37b Compare December 20, 2024 23:06

lavarou previously approved these changes Jan 3, 2025

View reviewed changes

hahuja2 modified the milestones: PHP 8.4 support, next-release Jan 6, 2025

bduranleau-nr reviewed Jan 6, 2025

View reviewed changes

agent/config.m4 Show resolved Hide resolved

bduranleau-nr reviewed Jan 6, 2025

View reviewed changes

agent/tests/test_agent.c Show resolved Hide resolved

bduranleau-nr reviewed Jan 6, 2025

View reviewed changes

tests/integration/api/error_group_callback/test_error_group_callback_error_web.php84.php Show resolved Hide resolved

ZNeumann dismissed lavarou’s stale review via 2ee7d4e January 7, 2025 15:54

bduranleau-nr previously approved these changes Jan 7, 2025

View reviewed changes

ZNeumann dismissed bduranleau-nr’s stale review via 3585eba January 7, 2025 20:21

ZNeumann and others added 7 commits January 7, 2025 14:34

chore(test): bump monolog2 to 2.10

d5c9ffa

chore(test): bump monolog3 to 3.8

97da69a

chore(test): bump guzzle to 7.9.2

4d42663

new guzzle 7 version requires PHP 8.1

7a4188b

fix ZEND_8_4_X_API_NO value (#992)

d5c2e7b

`ZEND_MODULE_API_NO` for PHP 8.4 is actually `20240924`.

add clarifying comments for test splits

1fc44ee

ZNeumann and others added 2 commits January 7, 2025 14:34

update clm lineno

a255b18

ZNeumann force-pushed the php84 branch from 1e81310 to 188b173 Compare January 7, 2025 21:34

ZNeumann requested review from bduranleau-nr and lavarou January 7, 2025 21:45

zsistla previously approved these changes Jan 7, 2025

View reviewed changes

sidneyprins reviewed Jan 8, 2025

View reviewed changes

fix typo

654f61b

ZNeumann dismissed zsistla’s stale review via 654f61b January 8, 2025 15:07

bduranleau-nr approved these changes Jan 8, 2025

View reviewed changes

lavarou approved these changes Jan 8, 2025

View reviewed changes

ZNeumann merged commit 34d720e into dev Jan 8, 2025
64 checks passed

ZNeumann deleted the php84 branch January 8, 2025 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PHP 8.4 #996

feat: PHP 8.4 #996

ZNeumann commented Dec 12, 2024 •

edited

Loading

newrelic-php-agent-bot commented Dec 12, 2024 •

edited

Loading

codecov-commenter commented Dec 12, 2024 •

edited

Loading

lavarou left a comment

zsistla left a comment

sidneyprins Jan 8, 2025

ZNeumann Jan 8, 2025

sidneyprins Jan 8, 2025

sidneyprins Jan 8, 2025

ZNeumann Jan 8, 2025

sidneyprins Jan 8, 2025

ZNeumann Jan 8, 2025

lavarou left a comment

feat: PHP 8.4 #996

feat: PHP 8.4 #996

Conversation

ZNeumann commented Dec 12, 2024 • edited Loading

newrelic-php-agent-bot commented Dec 12, 2024 • edited Loading

codecov-commenter commented Dec 12, 2024 • edited Loading

Codecov Report

lavarou left a comment

Choose a reason for hiding this comment

zsistla left a comment

Choose a reason for hiding this comment

sidneyprins Jan 8, 2025

Choose a reason for hiding this comment

ZNeumann Jan 8, 2025

Choose a reason for hiding this comment

sidneyprins Jan 8, 2025

Choose a reason for hiding this comment

sidneyprins Jan 8, 2025

Choose a reason for hiding this comment

ZNeumann Jan 8, 2025

Choose a reason for hiding this comment

sidneyprins Jan 8, 2025

Choose a reason for hiding this comment

ZNeumann Jan 8, 2025

Choose a reason for hiding this comment

lavarou left a comment

Choose a reason for hiding this comment

ZNeumann commented Dec 12, 2024 •

edited

Loading

newrelic-php-agent-bot commented Dec 12, 2024 •

edited

Loading

codecov-commenter commented Dec 12, 2024 •

edited

Loading