Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove usage of non-thread safe HashSet in AwsSdk pipeline wrappers #2856

Closed
wants to merge 2 commits into from

Conversation

gjunge
Copy link

@gjunge gjunge commented Oct 26, 2024

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Fixes issue found in #2855. Instead of using the HashSet<string> we use the ConcurrentHashSet<string>, similar as being used in NewRelic.Providers.Wrappers.AwsLambda.HandlerMethodWrapper.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@gjunge gjunge requested a review from a team as a code owner October 26, 2024 10:12
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

@tippmar-nr
Copy link
Member

Replaced by #2857

@tippmar-nr tippmar-nr closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants