Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove FID #1319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Remove FID #1319

wants to merge 1 commit into from

Conversation

ptang-nr
Copy link
Contributor

First Input Delay (FID) has been deprecated and replaced by Interaction To Next Paint (INP). PageViewTiming events for first interactions are preserved by detecting the first INP instead of FID event, and will no longer output value for the firstInputDelay attribute. For more info on PageViewTiming, see https://docs.newrelic.com/docs/browser/new-relic-browser/page-load-timing-resources/pageviewtiming-async-or-dynamic-page-details/. For more info on INP and the deprecation, see https://web.dev/articles/inp.

Overview

In this PR, we are proceeding with the removal of FID related logic from the browser agent.

Notes:

  • The firstInteraction timing event should continue to be detected as-is, with the exception of slight changes to the actual interactionType values:
    • old values from FID: pointerdown, pointerup, click; new value from INP: pointer
    • old values from FID: keydown, keyup; new value from INP: keyboard

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-355558

Testing

Updated existing tests that dealt with FID.

Preserve `firstInteraction` by detecting the first INP instead of FID event.
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.75 kB / 10.79 kB (gzip) 29.75 kB / 10.79 kB (gzip) 0% / -0.01% (gzip)
lite async-chunk 52.42 kB / 17.01 kB (gzip) 50.9 kB / 16.62 kB (gzip) -2.89% / -2.33% (gzip)
pro loader 51.4 kB / 17.74 kB (gzip) 51.4 kB / 17.74 kB (gzip) 0% / 0% (gzip)
pro async-chunk 99.25 kB / 30.31 kB (gzip) 97.6 kB / 29.87 kB (gzip) -1.66% / -1.46% (gzip)
spa loader 59.02 kB / 20.07 kB (gzip) 59.02 kB / 20.07 kB (gzip) 0% / 0% (gzip)
spa async-chunk 113.96 kB / 34.65 kB (gzip) 112.31 kB / 34.2 kB (gzip) -1.45% / -1.29% (gzip)

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (e7e0114) to head (aa5344f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   88.66%   88.66%   -0.01%     
==========================================
  Files         170      170              
  Lines        7321     7312       -9     
  Branches     1480     1478       -2     
==========================================
- Hits         6491     6483       -8     
  Misses        715      715              
+ Partials      115      114       -1     
Flag Coverage Δ
integration-tests 91.32% <100.00%> (+0.04%) ⬆️
unit-tests 79.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 11, 2025

Static Badge

Last ran on January 10, 2025 21:33:03 CST
Checking merge of (aa5344f) into main (e7e0114)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant