Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Metrics harvest only on EoL for new Harvester #1311

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Jan 8, 2025

Prevent Metrics feature from harvesting on interval after changes in v1.278.0. This reverts its behavior back to sending only final harvests.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-356543

Testing

New component test added for this case

Copy link

github-actions bot commented Jan 8, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.75 kB / 10.79 kB (gzip) 29.75 kB / 10.79 kB (gzip) 0% / 0.02% (gzip)
lite async-chunk 52.4 kB / 17.01 kB (gzip) 52.46 kB / 17.03 kB (gzip) 0.1% / 0.09% (gzip)
pro loader 51.4 kB / 17.74 kB (gzip) 51.4 kB / 17.74 kB (gzip) 0% / -0.01% (gzip)
pro async-chunk 99.23 kB / 30.3 kB (gzip) 99.29 kB / 30.32 kB (gzip) 0.05% / 0.06% (gzip)
spa loader 59.02 kB / 20.07 kB (gzip) 59.02 kB / 20.07 kB (gzip) 0% / 0% (gzip)
spa async-chunk 113.95 kB / 34.64 kB (gzip) 114 kB / 34.66 kB (gzip) 0.05% / 0.05% (gzip)

Copy link
Member

@metal-messiah metal-messiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once tests run

Copy link

github-actions bot commented Jan 8, 2025

Static Badge

Last ran on January 08, 2025 12:30:53 CST
Checking merge of (37ae0a2) into main (c22f253)

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (c22f253) to head (37ae0a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   88.54%   88.58%   +0.04%     
==========================================
  Files         170      170              
  Lines        7325     7325              
  Branches     1480     1481       +1     
==========================================
+ Hits         6486     6489       +3     
+ Misses        723      720       -3     
  Partials      116      116              
Flag Coverage Δ
integration-tests 91.28% <100.00%> (ø)
unit-tests 79.67% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 merged commit 5cecedc into main Jan 8, 2025
31 of 32 checks passed
@cwli24 cwli24 deleted the metrics-harvest branch January 8, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants