Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing GHA deps #1297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ptang-nr
Copy link
Contributor

@ptang-nr ptang-nr commented Dec 23, 2024

GitHub Actions require the actions/checkout package in order for workflows to run.

Overview

In this PR, include the following missing dependencies that are required for the delete-experiment and branch-cleanup actions to run:

  • actions/checkout - always required essentially
  • actions/setup-node - since our actions will require node to run

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-347721

Testing

Replicated workflow in a private repo and successfully tested:

Delete Experiment

Prepare all required actions
Run ./.github/actions/s3-delete
Run npm install --prefix $GITHUB_ACTION_PATH/..
  
npm warn deprecated formidable@1.[2](https://github.com/ptang-nr/test-browser-app/actions/runs/12484778541/job/34842658805#step:5:2).6: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
npm warn deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed a public vulnerability with formidable dependency. Note that v9.0.0+ requires Node.js v[14](https://github.com/ptang-nr/test-browser-app/actions/runs/12484778541/job/34842658805#step:5:16).18.0+. See https://github.com/ladjs/superagent/pull/1800 for insight. This project is supported and maintained by the team at Forward Email @ https://forwardemail.net
added 208 packages, and audited 209 packages in 14s
25 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
Run node $GITHUB_ACTION_PATH/index.js \
  
Bucket name: ***
Looking up files with prefix 'experiments//ptang-add-github-actions'
Found 0 matching files
No files found to delete
Completed successfully

Branch Cleanup
Dev

Prepare all required actions
Run ./.github/actions/s3-delete
Run npm install --prefix $GITHUB_ACTION_PATH/..
  
npm warn deprecated formidable@1.[2](https://github.com/ptang-nr/test-browser-app/actions/runs/12484791423/job/34842692385#step:5:2).6: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
npm warn deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed a public vulnerability with formidable dependency. Note that v9.0.0+ requires Node.js v[14](https://github.com/ptang-nr/test-browser-app/actions/runs/12484791423/job/34842692385#step:5:15).18.0+. See https://github.com/ladjs/superagent/pull/1800 for insight. This project is supported and maintained by the team at Forward Email @ https://forwardemail.net
added 208 packages, and audited 209 packages in 17s
25 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
Run node $GITHUB_ACTION_PATH/index.js \
  
This is a dry run.
Bucket name: ***
Looking up files with prefix 'experiments/dev/ptang/add-github-actions'
Found 0 matching files
Completed successfully

Staging

Prepare all required actions
Run ./.github/actions/s3-delete
Run npm install --prefix $GITHUB_ACTION_PATH/..
  
up to date, audited [2](https://github.com/ptang-nr/test-browser-app/actions/runs/12484791423/job/34842692385#step:6:2)09 packages in 1s
25 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
Run node $GITHUB_ACTION_PATH/index.js \
  
This is a dry run.
Bucket name: ***
Looking up files with prefix 'experiments/staging/ptang/add-github-actions'
Found 0 matching files
Completed successfully

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.13 kB / 10.86 kB (gzip) 30.13 kB / 10.86 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.39 kB / 17.35 kB (gzip) 53.39 kB / 17.35 kB (gzip) 0% / 0% (gzip)
pro loader 51.67 kB / 17.76 kB (gzip) 51.67 kB / 17.76 kB (gzip) 0% / 0% (gzip)
pro async-chunk 101.99 kB / 31.12 kB (gzip) 101.99 kB / 31.12 kB (gzip) 0% / 0% (gzip)
spa loader 59.29 kB / 20.1 kB (gzip) 59.29 kB / 20.1 kB (gzip) 0% / 0% (gzip)
spa async-chunk 116.66 kB / 35.39 kB (gzip) 116.66 kB / 35.39 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (a6a1bb7) to head (4100a69).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files         170      170           
  Lines        7431     7431           
  Branches     1497     1497           
=======================================
  Hits         6613     6613           
  Misses        697      697           
  Partials      121      121           
Flag Coverage Δ
unit-tests 79.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metal-messiah
metal-messiah previously approved these changes Dec 24, 2024
@ptang-nr ptang-nr force-pushed the NR-347721-add-missing-deps branch from 229e35b to 4100a69 Compare December 24, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants