security workflow does not repeat nightly scans #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavSanchez
reviewed
Jan 10, 2025
Comment on lines
-69
to
-79
| notify-failure: | ||
| if: ${{ github.event_name == 'schedule' && failure() }} | ||
| needs: [build] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Notify failure via Slack | ||
| uses: archive/github-actions-slack@master | ||
| with: | ||
| slack-bot-user-oauth-access-token: ${{ secrets.COREINT_SLACK_TOKEN }} | ||
| slack-channel: ${{ secrets.CAOS_COREINT_SLACK_CHANNEL }} | ||
| slack-text: "❌ `'newrelic/infrastructure-bundle'`: [security pipeline failed](${{ github.server_url }}/newrelic/infrastructure-bundle/actions/runs/${{ github.run_id }})." |
There was a problem hiding this comment.
I get we remove the repeated Trivy check, but do we want to get rid of the notify failure step?
There was a problem hiding this comment.
It only notifies failure if github.event_name == 'schedule' .
We are no longer running this with schedule because we have the nightly.
For failure on push PR the action will upload the results to the workflow on both success and failure.
rahulreddy15
force-pushed
the
NR-339698-Migrate-security-workflow-in-infrastructure-bundle-to-use-coreint-automation
branch
from
27ad5d5 to
2c15af1
Compare
rahulreddy15
deleted the
NR-339698-Migrate-security-workflow-in-infrastructure-bundle-to-use-coreint-automation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reusable security workflow (https://github.com/newrelic/coreint-automation/blob/8e5f750ba1e151b93454c56aeb1f6dbcea0e3b00/.github/workflows/reusable_security.yaml) scans the repo ( codebase ) for vulnerabilities with Trivy.
This cannot be used for
infrastructure-bundlebecause we need to build a docker Image and then scan that docker image for vulnerabilities by running trivy in table-mode.We have code that does this in the reusable nightly workflow for docker images. But that workflow also publishes the nightly build so reusing it just to scan the image on pull request does not make sense.
The code that runs the security check on a schedule can be removed because that is being handled by the nightly.
The code that runs the security check on a pull request should be left as is since we do not have a reusable workflow that only builds and scans a docker image.