Bug fixes for security agent #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #843 +/- ##
===========================================
- Coverage 80.26% 79.73% -0.54%
===========================================
Files 139 134 -5
Lines 12608 12494 -114
===========================================
- Hits 10120 9962 -158
- Misses 2197 2229 +32
- Partials 291 303 +12 ☔ View full report in Codecov by Sentry. |
nr-swilloughby
approved these changes
Jan 25, 2024
| @@ -163,9 +163,9 @@ func ConfigSecurityValidatorServiceEndPointUrl(url string) ConfigOption { | |||
| } | |||
|
|
|||
| // ConfigSecurityDetectionDisableRxss is used to enable or disable RXSS validation. | |||
| func ConfigSecurityDetectionDisableRxss(isEnabled bool) ConfigOption { | |||
| func ConfigSecurityDetectionDisableRxss(isDisable bool) ConfigOption { | |||
There was a problem hiding this comment.
Recommend renaming isDisable to isDisabled to be grammatically correct.
There was a problem hiding this comment.
We can change this as we prep for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes