Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate builder to typescript #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pkspyder007
Copy link

This PR aims to move neutralino builder to typescript for better developer experience and make easier for new contributors to get started with the project.

It uses esbuild instead of default tsc compiler to speed up the compile step

to compile run npm run build
this will check for typescript errors and generate declaration files and run esbuild to bundle for distribution

@pkspyder007
Copy link
Author

@shalithasuranga Any updates on this?

@SalihuDickson SalihuDickson marked this pull request as ready for review February 8, 2023 11:27
@SalihuDickson
Copy link
Collaborator

The plugin isn't working for the arm64 architecture in the app image linux build.
To test:

  1. install the plugin on the neutralino cli
  2. build an app with the neutralino cli named 'my-app'
  3. In the built app run the command neu builder appimage --arm64
  4. there should be an app image file with the name 'my-app-aarch64.Appimage' in the dist folder

@SalihuDickson
Copy link
Collaborator

The .tmp file in the directory of the app to be packaged is not being deleted after packaging.
To test:

  1. install the plugin on the neutralino cli
  2. build an app with the neutralino cli
  3. in the built app run the command to package with any target and for any architecture, for example neu builder appimage --arm64
  4. after the app is packaged, check for a hidden file in the folder '.tmp'. It should not exist.

@SalihuDickson
Copy link
Collaborator

There is some inconsistencies in the way require and import statements are written. Most files use the es6 type 'import' and some still use 'require'. Please make sure 'require' is only used where absolutely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants