-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an inflation factor to correct for multiple contrasts in Stouffer's combination test #117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 87.79% 88.07% +0.28%
==========================================
Files 13 13
Lines 893 914 +21
==========================================
+ Hits 784 805 +21
Misses 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through this, but did not confirm the equations, I think this is fine, so I'm not going to hold this up any longer
This PR expands Stouffer's combination test to correct for multiple contrasts. Developed by @nicholst.
In this method, we add a correction factor to account for repeated scans (i.e., multiple samples from the same study).
A braking change here that might affect the current implementation of Stouffer's IBMA in NiMARE is the dataset attribute mapping in
StoufferCombinationTest
. Previously, we mapped thev
(study-level variance) tow
(weights for weighted Stouffer's). In this PR, I thought of mapping then
(study-level sample sizes) tow
and thenv
tog
(array of group labels to determine the inflation factor).