Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an inflation factor to correct for multiple contrasts in Stouffer's combination test #117

Merged
merged 13 commits into from
Apr 9, 2024

Conversation

JulioAPeraza
Copy link
Collaborator

This PR expands Stouffer's combination test to correct for multiple contrasts. Developed by @nicholst.
In this method, we add a correction factor to account for repeated scans (i.e., multiple samples from the same study).

A braking change here that might affect the current implementation of Stouffer's IBMA in NiMARE is the dataset attribute mapping in StoufferCombinationTest. Previously, we mapped the v (study-level variance) to w (weights for weighted Stouffer's). In this PR, I thought of mapping the n (study-level sample sizes) to w and then v to g (array of group labels to determine the inflation factor).

@JulioAPeraza JulioAPeraza added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Apr 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (bee163b) to head (19fef11).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   87.79%   88.07%   +0.28%     
==========================================
  Files          13       13              
  Lines         893      914      +21     
==========================================
+ Hits          784      805      +21     
  Misses        109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulioAPeraza JulioAPeraza requested a review from jdkent April 3, 2024 16:06
Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through this, but did not confirm the equations, I think this is fine, so I'm not going to hold this up any longer

@jdkent jdkent merged commit 7465939 into neurostuff:master Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants