-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StanMetaRegression estimator #108
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 87.79% 90.85% +3.06%
==========================================
Files 13 13
Lines 893 897 +4
==========================================
+ Hits 784 815 +31
+ Misses 109 82 -27 ☔ View full report in Codecov by Sentry. |
Tests on Python 3.6 are failing because PyStan 3 only works for Python 3.7+. @tsalo, do you think we should remove the test on 3.6 completely, or there is a way to just skip 3.6 for The other tests on ubuntu-latest (20.04.4) failed with an error that was already reported here: https://discourse.mc-stan.org/t/schools-example-not-compiling-pystan-3-4-on-ubuntu-20-04-4/27812. |
I'm thinking that we should (1) mark the pystan tests with a decorator and try to skip them with 3.6, (2) ensure that pystan is an optional dependency, (3) include in our documentation that users should not try using pystan with PyMARE and Python 3.6, and (4) add some type of warning based on the import and Python version within the StanMetaRegression estimator at initialization. |
Thanks! I have added the decorators and included pystan as an optional dependency and the tests are now passing. I still need to find what's happening to the test on ubuntu-latest (20.04.4). |
Now all tests are passing after switching to ubuntu 20.04 for Python 3.6. |
…nto fix-pystan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @JulioAPeraza!
Closes #67.
Changes proposed in this pull request:
StanMetaRegression
code to work with the new PyStan's API (PyStan 3).test_stan_estimators
.