-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bounding boxes' tracks --> bounding boxes tracks #392
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 15 15
Lines 1048 1048
=======================================
Hits 1046 1046
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sfmig for the small victory 😜
Just a general thought/question: given we have 'pose tracks', does it make more sense to have 'bounding box tracks' rather than 'bounding boxes tracks'? If we opt for the singular term, we could also use 'bounding box centroids' 🪱
My two cents on this: personally I much prefer the singular "box" in "bounding box tracks" or "bounding box centroids". Afaik it's grammatically ok, since the plural is expressed in the "tracks" or "centroids". That said, I'm aware we had a vote on this (slack poll), and I think the version with the plural + apostrophe won out (as in "poses' tracks"). For reasons already stated I dislike the apostrophe so we are back to square one? To bring this not-so-important issue to a close, I'm fine with either "bounding box tracks" or "bounding boxes tracks", but whatever we end up using should also apply to centroids. |
33a6f4f
to
4f39b69
Compare
Quality Gate passedIssues Measures |
Description
A small win towards next term 😉
What is this PR
Why is this PR needed?
There was inconsistency in our docs when referring to bounding boxes trajectories.
What does this PR do?
References
#357
How has this PR been tested?
Tests pass locally and in CI
Is this a breaking change?
No.
Does this PR require an update to the documentation?
It includes an update to the docstrings.
Checklist: