Create cisco_asa_show_running-config_object_service #1970
+406
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wollmannbruno
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
reviewed
Jan 10, 2025
ntc_templates/templates/cisco_asa_show_running-config_object_service.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Jan 10, 2025
Comment on lines
+4
to
+13
| Value SRC_PORT_EQ (\S+) | ||
| Value SRC_PORT_GT (\S+) | ||
| Value SRC_PORT_LT (\S+) | ||
| Value SRC_PORT_START (\S+) | ||
| Value SRC_PORT_END (\S+) | ||
| Value DST_PORT_EQ (\S+) | ||
| Value DST_PORT_GT (\S+) | ||
| Value DST_PORT_LT (\S+) | ||
| Value DST_PORT_START (\S+) | ||
| Value DST_PORT_END (\S+) |
There was a problem hiding this comment.
@wollmannbruno
I have some ideas regarding all the port capture groups.
If I work up a PR against your fork would you be willing to review/consider the changes?
I want to make sure my thoughts to simplify align with your expectations/needs/process. Thank you!
There was a problem hiding this comment.
@mjbear
If we can simplify the template, we should.
Send over your changes, and I'll test them against a production firewall.
…ervice.textfsm Co-authored-by: Michael Bear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1968.