Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hp_comware_display_interface.textfsm #1963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliencorsini
Copy link

Fixed frame regexp for hp_comware_display_interface.textfsm in case of non null frame count.
Fixes #1950

Fixed frame regexp for hp_comware_display_interface.textfsm in case of non null frame count.
@@ -180,7 +180,7 @@ Start
^\s*GRE
^\s*Checksumming\sof\sGRE
^\s+-\s+ignored
^\s+-\s+frame
^\s+[-\d]+\s+frame
Copy link
Contributor

@mjbear mjbear Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we want -1 or 1-.

I believe the below regex is what we're looking for.
(You'll be able to accept my suggestion by clicking "commit suggestion".)

Suggested change
^\s+[-\d]+\s+frame
^\s+(-|\d+)\s+frame

@mjbear
Copy link
Contributor

mjbear commented Jan 7, 2025

Fixed frame regexp for hp_comware_display_interface.textfsm in case of non null frame count. Fixes #1950

Based on my example on your other PR #1964, please include test data for this PR.

The required test data should include:

  • raw cli output (remove/sanitize sensitive info)
  • and generate structured YAML data with helper scripts

Information about setting up your development environment.

Edit: You'll also want to rebase your patch-1 branch off of the current state of the NTC master branch. It's not all that difficult, but it is a small hurdle. The reason to do this is to make sure there aren't any merge conflicts (and if there are conflicts you can resolve them early).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hp_comware_display_interface.textfsm failing on multiline counters
2 participants