Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for capturing the "Local Intf service instance" field in the template. #1957

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Added support for capturing the "Local Intf service instance" field in the template. #1957

merged 1 commit into from
Jan 7, 2025

Conversation

RandyRozo
Copy link
Contributor

resolves #1954

  • Included the line ^Local\s+Intf\s+service\s+instance in the template to handle cases where this field appears in the CLI output.
  • Improved template compatibility with various configurations and test data.

Added support for capturing the "Local Intf service instance" field i…
160a434 
…n the template.

- Included the line ^Local\s+Intf\s+service\s+instance in the template to handle cases where this field appears in the CLI output.
- Improved template compatibility with various configurations and test data.
mjbear
mjbear approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@mjbear mjbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Now for the maintainers to give their blessing. 😉

@jmcgill298 jmcgill298 merged commit 9a3e8d2 into networktocode:master Jan 7, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbear mjbear mjbear approved these changes

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cisco_ios_show_lldp_neighbors_detail.textfsm: Missing validation for 'Local Intf service instance:' line.
3 participants
@RandyRozo @jmcgill298 @mjbear