Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco_asa_show_running-config_object_network.textfsm #1952

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

ppisnjak
Copy link
Contributor

Added better FQDN object support. Cisco ASA config shows following options:
network-object mode commands/options:
WORD < 128 char Fully Qualified Domain Name - FQDN must begin and end with a digit/letter. Only letters, digits, and hyphen are allowed as internal characters. Labels are separated by a dot.
v4 IPv4 FQDN object
v6 IPv6 FQDN object

Objects can be specified as v4 or v6 or can be created without specification. This enables correct parsing since before they would be parsed as "v4" or "v6".

Added better FQDN object support. Cisco ASA config shows following options:
network-object mode commands/options:
  WORD < 128 char  Fully Qualified Domain Name - FQDN must begin and end with a digit/letter. Only letters, digits, and hyphen are allowed as internal characters. Labels are separated by a dot.
  v4               IPv4 FQDN object
  v6               IPv6 FQDN object

Objects can be specified as v4 or v6 or can be created without specification. This enables correct parsing since before they would be parsed as "v4" or "v6".
@mjbear
Copy link
Contributor

mjbear commented Dec 30, 2024

Added better FQDN object support. Cisco ASA config shows following options: network-object mode commands/options: WORD < 128 char Fully Qualified Domain Name - FQDN must begin and end with a digit/letter. Only letters, digits, and hyphen are allowed as internal characters. Labels are separated by a dot. v4 IPv4 FQDN object v6 IPv6 FQDN object

Objects can be specified as v4 or v6 or can be created without specification. This enables correct parsing since before they would be parsed as "v4" or "v6".

Howdy @ppisnjak
Thank you for your contribution!

  1. I worked up a minor PR Regenerate existing parsed data for ASA show run obj network ppisnjak/ntc-templates#1 against your patch-1 branch to regenerate existing parsed data.

    • You're able to review my PR against your branch/PR and easily accept my changes into your branch if they pass your review. 😅
  2. Would you please add a short file of some sanitized test data?

    • Based on the diffs of the current data, there isn't test data for the bug you found.
    • Once you have test data, you can create a new file in addition to the existing one in the designated path and use helper scripts to generate the parsed YAML data.
    • Commit both the raw CLI output and the parsed YAML to (your branch for) this PR to provide test coverage.

Thank you!

ppisnjak and others added 2 commits December 30, 2024 21:59
Regenerate existing parsed data for ASA show run obj network
…etwork.textfsm


I agree, honestly this is my first commit so, not sure what is the best practice.

Co-authored-by: Michael Bear <[email protected]>
@ppisnjak
Copy link
Contributor Author

ppisnjak commented Jan 7, 2025

@mjbear Thanks for assistance! Since this is my first pull request ever, what is the following procedure? We just wait for code owners approve or is there something else needed? Thanks!

@mjbear
Copy link
Contributor

mjbear commented Jan 7, 2025

@mjbear Thanks for assistance! Since this is my first pull request ever, what is the following procedure? We just wait for code owners approve or is there something else needed? Thanks!

That is correct.
After it has been a week or so I tend to gently nudge the maintainers.
As of late we're stacking up some PRs and they've been cranking through some of them today. 😁

Note: I was being a bit silly with IPv10, but I'm good with the regex as it doesn't hurt! 🫠

@jmcgill298 jmcgill298 merged commit 33f4faa into networktocode:master Jan 7, 2025
10 checks passed
@ppisnjak ppisnjak deleted the patch-1 branch January 8, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants