Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei smartax display ont info summary #1944

Conversation

evilmonkey19
Copy link
Contributor

@evilmonkey19 evilmonkey19 commented Dec 23, 2024

Fixing bug when having multiple outputs from different ports

@mjbear
Copy link
Contributor

mjbear commented Dec 23, 2024

Fixing bug when having multiple outputs from different ports

Howdy @evilmonkey19!
There are some merge conflicts that need fixed up. I'll see about these later today.

I have a few thoughts on some regexes, but it won't be until later that I can monkey with those to see how what I think translates when parsing the test data.

@evilmonkey19
Copy link
Contributor Author

Howdy @mjbear ! No problem 😄. I know that aren't the best templates ever, but they are quite difficult to do, specially because of the multiple ports output.

@mjbear
Copy link
Contributor

mjbear commented Dec 24, 2024

@evilmonkey19
I submitted a PR evilmonkey19#4 against your branch to clean up the merge conflicts.

Other items:
🎯 There's a template for huawei_smartax_display_ont_info_summary_sn.textfsm in this PR as well. Was that intended?

🌎 It does not appear there is test data for the summary_sn template.

Thank you.
Merry Christmas! 🎄

@evilmonkey19
Copy link
Contributor Author

Howdy @mjbear!

This is not quite an usual template as you may see that there are multiple tables into one. The technique used here is using two templates and do the matching using the key keyword. Instead of seeing both as 2 separate templates you should see them as only one. Actually, the resulting YAML file have variables from both templates. For instance, just looking at one template and the resulting YAML you will more variables in the YAML file than in the template.

This is a special technique that @jvanderaa and @jmcgill298 told me long ago :)

@mjbear
Copy link
Contributor

mjbear commented Jan 7, 2025

Howdy @mjbear!

This is not quite an usual template as you may see that there are multiple tables into one. The technique used here is using two templates and do the matching using the key keyword. Instead of seeing both as 2 separate templates you should see them as only one. Actually, the resulting YAML file have variables from both templates. For instance, just looking at one template and the resulting YAML you will more variables in the YAML file than in the template.

Ah, that makes sense.

This is a special technique that @jvanderaa and @jmcgill298 told me long ago :)

Neat, I'll have to give this more of a look shortly.

@jmcgill298 jmcgill298 merged commit d747be0 into networktocode:master Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants