New template for Alcatel AOS: show lldp remote-system

[evilmonkey19]

It has support for R6 and R8 versions

[mjbear]

Looks like there are some capture group names to normalize.
It's going take some time to analyze. Thank you.

[mjbear]

@evilmonkey19
Why are so many of the capture group regexes .*?

Have you found things such as REMOTE_ID or the MAC address to be empty?

There's some weirdness from vendors' implementation of LLDP (I've seen that before as well) when it comes to what shows in some of those fields ... but not all of those fields from the looks of it.

[mjbear]

@evilmonkey19
Edit: Please disregard as this is already handled. Kudos!

Do we really want or care about a System (Neighbor) Description that contains (null)?

It may make sense to exclude that string and just bring back an empty string instead. This will avoid capturing data we (probably) don't care about and make things easier to programmatically check (ex: with Python boolean).

Edit2: I was seeing (null) in port description within the YAML and that's what I meant. Oh well, I'm going to handle that one.

[mjbear]

@evilmonkey19
Do we care about all possible Capabilities or just those that are enabled?

One example is the IOS or NXOS template where only the enabled capabilities matter so they're the only ones captured.

• https://github.com/networktocode/ntc-templates/blob/master/ntc_templates/templates/cisco_ios_show_lldp_neighbors_detail.textfsm
• https://github.com/networktocode/ntc-templates/blob/master/ntc_templates/templates/cisco_nxos_show_lldp_neighbors_detail.textfsm

[mjbear]

Submitted evilmonkey19/pull/3 to @evilmonkey19's fork.

Following normalized examples in https://github.com/networktocode/ntc-templates/blob/master/docs/dev/data_model.md

Alcatel AOS	Normalized
PORT	LOCAL_INTERFACE
CHASSIS	CHASSIS_ID
MAC_PORT	MAC_ADDRESS
REMOTE_ID	?
CHASSIS_SUBTYPE	?
PORT_SUBTYPE	?
PORT_DESCRIPTION	NEIGHBOR_INTERFACE
SYSTEM_NAME	NEIGHBOR_NAME
SYSTEM_DESCRIPTION	NEIGHBOR_DESCRIPTION
CAPABILITIES_SUPPORTED	question posed in /pull/1917
CAPABILITIES_ENABLED	question posed in /pull/1917
MANAGEMENT_IP_ADDRESS	MGMT_ADDRESS
MED_DEVICE_TYPE	?
MED_CAPABILITIES	?
MED_EXTENSION_TLVS_PRESENT	?
MED_POWER_TYPE	POWER_DEVICE_TYPE
MED_POWER_SOURCE	POWER_SOURCE
MED_POWER_PRIORITY	POWER_PRIORITY
MED_POWER_VALUE	POWER_REQUESTED
REMOTE_PORT_MAC_PHY_AUTONEG	?
MAU_TYPE	?

[evilmonkey19]

@evilmonkey19 Why are so many of the capture group regexes .*?

Have you found things such as REMOTE_ID or the MAC address to be empty?

There's some weirdness from vendors' implementation of LLDP (I've seen that before as well) when it comes to what shows in some of those fields ... but not all of those fields from the looks of it.

The main reason for such many .* it is not sure that the output will appear

[evilmonkey19]

I merged your PR in my repo because it looks great! I have tried against real data even 👍