Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors #1906

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

0lesen
Copy link
Contributor

@0lesen 0lesen commented Nov 21, 2024

Added Description

@0lesen 0lesen changed the title Update cisco_ios_show_ip_bgp_vpnv4_all_neighbors.textfsm Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors Nov 21, 2024
@mjbear
Copy link
Contributor

mjbear commented Nov 21, 2024

I have some suggestions I'll put forth, but that won't be until this evening.
Thank you. 🙂

@mjbear
Copy link
Contributor

mjbear commented Nov 22, 2024

@0lesen
Please provide raw output (which contains a BGP peer Description) in your PR.
(Replace any potentially sensitive information with similar placeholders.)

With that raw output, use the helper scripts to parse that raw output and add that into your PR too.

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_environment.md

Ask if you have questions. Thank you.

I'd be glad to re-review once there's test data. 😁

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @0lesen . As @mjbear requested, please update the test data to make this PR ready for review

@jmcgill298 jmcgill298 added the changes_requested Waiting on user to address feedback label Nov 25, 2024
@mjbear
Copy link
Contributor

mjbear commented Dec 11, 2024

@0lesen
I submitted a PR (0lesen/pull/1) against your patch.
This PR includes a few changes as well as test data (raw and structured yaml).

Thank you!

Template changes and test data for pr1906
@mjbear
Copy link
Contributor

mjbear commented Dec 17, 2024

Thank you @0lesen! 🇩🇰

If you have access to any different vpnv4 output please test against it and even include a sanitized example.

For example, I found that in the output I generated there was not a Local AS.

Let's make this template's test data fully cover any differences in the CLI output! 😀
Thank you!

@jmcgill298 jmcgill298 merged commit df99b8e into networktocode:master Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants