Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GTAA SPARQL endpoint #515

Merged
merged 18 commits into from
Mar 2, 2022
Merged

Use new GTAA SPARQL endpoint #515

merged 18 commits into from
Mar 2, 2022

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Feb 24, 2022

  • added one GTAA dataset for testing
  • added query variable as filter

Copy link
Member Author

@ddeboer ddeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the filenames of the .rq files match those in the jsonld data. Use dashes - (not underscore _) everywhere for consistency.

Also remove the old files to remove confusion: the new endpoint should replace the old one.

@ddeboer
Copy link
Member Author

ddeboer commented Feb 24, 2022

I cannot test these queries locally (because I have no access to the SPARQL endpoint), so I’m assuming they are correct.

@wmelder
Copy link
Contributor

wmelder commented Feb 27, 2022 via email

@wmelder
Copy link
Contributor

wmelder commented Feb 28, 2022

The Genre_Filmmuseum dataset can be left out of the network of terms for now. I will prepare a commit for that.

@wmelder
Copy link
Contributor

wmelder commented Mar 2, 2022

After merging master into branch these errors arise when running npm dev:

10:55:51 AM - File change detected. Starting incremental compilation...
../network-of-terms-catalog/src/catalog.ts(11,9): error TS2595: 'globby' can only be imported by using a default import.
../network-of-terms-catalog/src/catalog.ts(104,15): error TS7006: Parameter 'file' implicitly has an 'any' type.
10:55:52 AM - Found 2 errors. Watching for file changes.

@ddeboer ddeboer enabled auto-merge (squash) March 2, 2022 13:32
@ddeboer ddeboer disabled auto-merge March 2, 2022 13:32
@ddeboer ddeboer enabled auto-merge (squash) March 2, 2022 13:33
@ddeboer ddeboer merged commit 597f53a into master Mar 2, 2022
@ddeboer ddeboer deleted the gtaa branch March 2, 2022 13:33
@ddeboer
Copy link
Member Author

ddeboer commented Mar 2, 2022

And… merged. Thanks a lot for your contribution and patience @wmelder!

@ddeboer
Copy link
Member Author

ddeboer commented Mar 2, 2022

🎉 This PR is included in version 1.49.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Mar 2, 2022

🎉 This PR is included in version 5.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Mar 2, 2022

🎉 This PR is included in version 1.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Mar 2, 2022

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Mar 8, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants