-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new GTAA SPARQL endpoint #515
Conversation
ddeboer
commented
Feb 24, 2022
- added one GTAA dataset for testing
- added query variable as filter
packages/network-of-terms-catalog/catalog/datasets/gtaa_persoonsnamen.jsonld
Outdated
Show resolved
Hide resolved
packages/network-of-terms-catalog/catalog/datasets/genre_filmmuseum.jsonld
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the filenames of the .rq
files match those in the jsonld
data. Use dashes -
(not underscore _
) everywhere for consistency.
Also remove the old files to remove confusion: the new endpoint should replace the old one.
packages/network-of-terms-catalog/catalog/datasets/gtaa_onderwerpen_beng.jsonld
Outdated
Show resolved
Hide resolved
packages/network-of-terms-catalog/catalog/datasets/gtaa_namen.jsonld
Outdated
Show resolved
Hide resolved
packages/network-of-terms-catalog/catalog/datasets/genre_filmmuseum.jsonld
Outdated
Show resolved
Hide resolved
I cannot test these queries locally (because I have no access to the SPARQL endpoint), so I’m assuming they are correct. |
packages/network-of-terms-catalog/catalog/datasets/filmmuseum-genres.rq
Outdated
Show resolved
Hide resolved
packages/network-of-terms-catalog/catalog/datasets/filmmuseum-genres.rq
Outdated
Show resolved
Hide resolved
packages/network-of-terms-catalog/catalog/datasets/filmmuseum-genres.rq
Outdated
Show resolved
Hide resolved
The GTAA URIs have HTTP as protocol, not https. They can be dereferenced without any authentication.
Verstuurd vanaf mijn iPhone
… Op 26 feb. 2022 om 17:49 heeft David de Boer ***@***.***> het volgende geschreven:
@ddeboer commented on this pull request.
In packages/network-of-terms-catalog/catalog/datasets/gtaa_persoonsnamen.jsonld:
> + ***@***.***": "https://schema.org/docs/jsonldcontext.jsonld",
+ ***@***.***": "http://data.beeldengeluid.nl/gtaa/Persoonsnamen",
+ ***@***.***": "Dataset",
+ "name": [
+ {
+ ***@***.***": "nl",
+ ***@***.***": "GTAA Persoonsnamen"
+ }
+ ],
+ "creator": [
+ {
+ ***@***.***": "https://www.beeldengeluid.nl/"
+ }
+ ],
+ "url": [
+ "http://data.beeldengeluid.nl/gtaa/Persoonsnamen"
I’ve just added some documentation to explain the need for the prefix. The Network of Terms has its own lookup functionality to present the same SKOS representation to clients as when they search for terms. Lookup is needed because:
some sources dereference URIs correctly but return it in their own vocabulary, such as Schema.org, rather than SKOS, which clients expect from the Network of Terms
other sources use SKOS internally but fail to dereference URIs, including GTAA (as of now):
$ curl -v -H Accept:application/ld+json https://data.beeldengeluid.nl/gtaa/30369
< HTTP/1.1 500 Internal Server Error
Could not find acceptable representation
even if sources dereference correctly and use SKOS, they may return values different from those returned by the Network of Terms search, which may be confusing for clients.
To know which term to source for a certain URI, the Network of Terms needs to know those prefixes.
Does that clear things up?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
|
The Genre_Filmmuseum dataset can be left out of the network of terms for now. I will prepare a commit for that. |
After merging master into branch these errors arise when running
|
And… merged. Thanks a lot for your contribution and patience @wmelder! |
🎉 This PR is included in version 1.49.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.7.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |