Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parameterize results limit #1479

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: Parameterize results limit #1479

merged 1 commit into from
Dec 20, 2024

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Dec 19, 2024

  • Use subqueries for all sources to be able to limit on number
    of CONSTRUCTed terms instead of SPARQL bindings.
  • Parameterize SPARQL limit. Because LIMIT cannot take a
    pre-bound variable (LIMIT ?limit), we need to introduce
    a placeholder (#LIMIT#) and replace that manually.
  • Order GTM and Wikidata results by relevance.
  • Add GraphQL parameter limit.
  • Default limit for reconciliation, CLI as well as GraphQL to 100 terms.

Ref #1367
Ref #36
Replace #943
Fix #1477

@ddeboer ddeboer force-pushed the parameterize-limit branch 2 times, most recently from 383f080 to 3fa129f Compare December 19, 2024 21:36
@ddeboer ddeboer force-pushed the parameterize-limit branch 2 times, most recently from dd34451 to af127a8 Compare December 20, 2024 13:13
@ddeboer ddeboer enabled auto-merge (squash) December 20, 2024 13:14
@ddeboer ddeboer disabled auto-merge December 20, 2024 13:14
@ddeboer ddeboer enabled auto-merge (squash) December 20, 2024 13:22
@ddeboer ddeboer merged commit a61573b into master Dec 20, 2024
2 checks passed
@ddeboer ddeboer deleted the parameterize-limit branch December 20, 2024 13:23
@ddeboer
Copy link
Member Author

ddeboer commented Dec 20, 2024

🎉 This PR is included in version 5.5.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Dec 20, 2024

🎉 This PR is included in version 9.19.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀


CONSTRUCT {
?piduri a skos:Concept ;
skos:prefLabel ?prefLabel ;
skos:altLabel ?altLabel;
skos:scopeNote ?scopeNote ;
skos:related ?related_uri ;
skos:exactMatch ?exactMatch_uri .
skos:exactMatch ?exactMatch_uri ;
vrank:simpleRank ?score .
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coret No vrank:simpleRank was being returned yet in the GTM query, so luc:score was ignored. I added simpleRank so results are actually returned in ranked order now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL: pagination/limit support for Terms
1 participant