Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add link to dataset page #1147

Merged
merged 14 commits into from
Nov 11, 2023
Merged

feat!: Add link to dataset page #1147

merged 14 commits into from
Nov 11, 2023

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Oct 28, 2023

BREAKING CHANGE: for custom catalogs, add a schema:mainEntityOfPage
property to each dataset.

@ddeboer
Copy link
Member Author

ddeboer commented Oct 28, 2023

@rschalkrce I used the property schema:mainEntityOfPage. Please check all my suggestions in the catalog, paying particular attention to the https://??? values that I could not find any good webpage for.

Copy link
Contributor

@rschalkrce rschalkrce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddeboer ,

I've added a URL to mainEntityOfPage where I could find one. Some are still open. For these I would suggest to continue to use the url value for now (I have not done that yet).

@ddeboer ddeboer force-pushed the human-readable-dataset-url branch from 779836b to 6182c2f Compare November 11, 2023 13:30
@ddeboer ddeboer requested a review from rschalkrce November 11, 2023 13:31
@ddeboer ddeboer merged commit 229a47d into master Nov 11, 2023
2 checks passed
@ddeboer ddeboer deleted the human-readable-dataset-url branch November 11, 2023 13:35
@ddeboer
Copy link
Member Author

ddeboer commented Nov 11, 2023

🎉 This PR is included in version 4.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Nov 11, 2023

🎉 This PR is included in version 8.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants