feat: Add distribution analyzer #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
commented
Nov 30, 2023
| <https://schema.org/target> <https://www.openarchieven.nl/foundlinks/linkset/33ff3fa4744db564807b99dbc4a3d012.nt.gz>; | ||
| <https://schema.org/error> 404. | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@EnnoMeijers @coret Does this data model make sense?
There was a problem hiding this comment.
Looking at the Schema.org spec this seems to fit well. I am just trying to figure out if schema:object would be more appropriate than schema:tartget but I am not sure, so let's keep at schema:target. Should we use https://www.w3.org/2011/http-statusCodes#404 instead of just 404?
There was a problem hiding this comment.
Should we use https://www.w3.org/2011/http-statusCodes#404 instead of just 404?
I agree we should prefer URIs over literals. Unfortunately, https://www.w3.org/2011/http-statusCodes#404 is not a valid URI; that should be https://www.w3.org/2011/http-statusCodes#NotFound.
ddeboer
force-pushed
the
distribution-analyzer
branch
2 times, most recently
from
fed22c5 to
0850d5f
Compare
ddeboer
force-pushed
the
distribution-analyzer
branch
from
0850d5f to
8065ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/2011/http-statusCodes.
Prepare for #1