Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI config: add spread operator #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Aug 14, 2017

  • bug fix? no
  • new feature? yes
  • BC break? yes (when someone concats ... with a scalar parameter. it could be fixed by checking whether return value is an array, but is it worth it?)

@matej21 matej21 force-pushed the feature/spread-operator branch from f9ed939 to 0891cbd Compare August 14, 2017 14:02
@matej21 matej21 force-pushed the feature/spread-operator branch from 0891cbd to e10cee9 Compare August 14, 2017 14:40
@dg
Copy link
Member

dg commented Aug 19, 2017

For accuracy: it is not like PHP spread operator, because it works with keys, so DbConnection(...%connection%) in NEON and new DbConnection(...$connection) in PHP may work different.

@dg dg force-pushed the master branch 5 times, most recently from 4243866 to e8187b3 Compare August 31, 2017 22:43
@f3l1x
Copy link
Member

f3l1x commented Feb 18, 2018

It would be fine merge it or reject it. What do you think? I could be the fine feature in Nette 3?

@dg dg force-pushed the master branch 2 times, most recently from e78d4c1 to b36d041 Compare March 28, 2018 23:57
@dg dg force-pushed the master branch 2 times, most recently from ec720a7 to 9d3541e Compare June 11, 2018 08:45
@dg dg force-pushed the master branch 3 times, most recently from 8224b32 to d51ca9e Compare September 16, 2018 21:16
@dg dg force-pushed the master branch 3 times, most recently from 1fc7645 to 485a875 Compare October 3, 2018 16:24
@dg dg added this to the v3.0 milestone Oct 3, 2018
@dg dg force-pushed the master branch 4 times, most recently from a27a10b to 594a33a Compare October 5, 2018 18:18
@dg dg force-pushed the master branch 3 times, most recently from 680bc12 to 5066242 Compare October 15, 2023 12:34
@dg dg force-pushed the master branch 3 times, most recently from b109822 to 7f11e6e Compare November 3, 2023 00:16
@dg dg force-pushed the master branch 2 times, most recently from ef39d2d to f729b1e Compare December 14, 2023 12:50
@dg dg force-pushed the master branch 9 times, most recently from a43bb2c to 71a91be Compare February 7, 2024 10:11
@dg dg force-pushed the master branch 2 times, most recently from 51cfed7 to 9c4af52 Compare February 12, 2024 17:55
@dg dg force-pushed the master branch 3 times, most recently from 0a1f0ab to 8c392ab Compare April 29, 2024 11:53
@dg dg force-pushed the master branch 2 times, most recently from 96c09bc to 7a40f39 Compare May 16, 2024 13:31
@dg dg force-pushed the master branch 2 times, most recently from 8655bcb to 59cf699 Compare December 2, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants