-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setup.py directives path #970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-enabling __h variable in place of dt inside numstep for synapses as it used by ode toolbox by default (it's probably better to use default and modify templates than to modify nestml unnecessarily) -removing some old comments from templates -replacing init() with calibrate for synapses -first proper initialization of propagators occurs inside of numstep due to missing __h variable inside calibrate() -generating variables from internals block in proper oder
kernel is not used, it is cm, otherwise it is synapse -fixing tests for cm -running context condition for cm only once, so it does not get run after neuron transformation (at wich point convolution calls are gone and cm inlines can't be recognized easily any more) -fixing import -fixing double initialization in compartmentCurrentClass.jinja2 -fixing log_message() so it accepts ASTInlineExpression
cm_syns with a derivative of the inline -fixing futher numstep bugs -small model fix
'get_name'" updating a comment while at it
an already transformed model (at which point those will look like ion channels due to now missing convolve() calls)
Fix segfaults somehow, don't know why this works...
fix variable names parameters in channel constructor
create a pull request
Conflicts: pynestml/cocos/co_co_buffer_data_type.py pynestml/cocos/co_co_buffer_not_assigned.py pynestml/cocos/co_co_buffer_qualifier_unique.py pynestml/cocos/co_co_current_buffers_not_specified.py
Make nestml defined state variables recordable
remove loading of erroneous model
-removing some comments -fixing other comments
to conform with naming conventions seen in the rest of the code, fixing a few comments
…t-buffer Fix segmentation fault related to spike buffer
…origin/LeanderEwert
…origin/LeanderEwert
# Conflicts: # setup.py
clinssen
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix setup.py directives path