Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit from seconds to Siemens #3314

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update unit from seconds to Siemens #3314

merged 1 commit into from
Oct 14, 2024

Conversation

anthropikos
Copy link
Contributor

There is a typo in the header file resulting in typo in the documentation.

clinssen
clinssen approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with NESTML (https://github.com/nest/nestml/blob/eaf1b3cf8aa5170e6436c7a269047745640a621c/models/neurons/aeif_cond_alpha_neuron.nestml#L75C1-L75C60). Thanks for the fix!

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 2, 2024
@jessica-mitchell jessica-mitchell changed the title Update unit from seconds to Siemens. Update unit from seconds to Siemens Oct 2, 2024
@jessica-mitchell
Copy link
Contributor

Merge with 1 reviewer as its documentation

@jessica-mitchell jessica-mitchell merged commit 0a019e4 into nest:master Oct 14, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthropikos @jessica-mitchell @clinssen