Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about maximum enforced timestep #3249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Jul 12, 2024

Add note about maximum enforced timestep in all aeif models.

@clinssen clinssen added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 12, 2024
@terhorstd
Copy link
Contributor

@clinssen, could you please provide a description for this PR?

@heplesser heplesser self-requested a review September 9, 2024 08:01
Comment on lines +108 to +109
A maximum integration step size of 10 μs is enforced, regardless of the
resolution set in the NEST kernel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. init_buffers_() initialises B_.IntegrationStep_ to min(0.01, Time::get_resolution().get_ms()), but after that the adaptive stepsize mechanism controls IntegrationStep_. The initialization line has been unchanged since 2.6.1 at least, and I am not sure why we have it at all, given that we are using an adaptive stepsize solver. It might be a leftover from very early versions with a fixed-stepsize solver.

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinssen I think in this case the code is actually wrong/outdated. We us an adaptive-stepsize solver, so we should not need to control the integration time step manually. See also inline comment. I'd suggest to change the code instead (but check for consequences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants