Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spike rate physical units from Hz to spks/s #3136

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Fix spike rate physical units from Hz to spks/s #3136

merged 7 commits into from
Dec 9, 2024

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Mar 5, 2024 •
edited
Loading

With props to @abigailm

I would suggest @tomtetzlaff as a second reviewer.

jessica-mitchell
jessica-mitchell approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then this looks good to me

@clinssen clinssen added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 11, 2024
heplesser
heplesser requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some small suggestions. And obviously I do not see here what you may have overlooked.

pynest/examples/balancedneuron.py Outdated Show resolved Hide resolved
pynest/nest/raster_plot.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jul 15, 2024
@terhorstd
Copy link
Contributor

Could you please provide a short description for this PR?

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Jul 25, 2024
@clinssen clinssen changed the title Fix raster plot physical units in label Fix spike rate physical units from Hz to spks/s Dec 9, 2024
@clinssen clinssen requested a review from heplesser December 9, 2024 10:29
heplesser
heplesser requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinssen Looks good, I just have one small correction, see inline.

pynest/examples/one_neuron_with_noise.py Outdated Show resolved Hide resolved
@clinssen @heplesser
fix spike rate physical units
fc1e4fd 
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
@clinssen clinssen requested a review from heplesser December 9, 2024 13:46
@heplesser heplesser merged commit c98ff79 into master Dec 9, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clinssen @terhorstd @heplesser @jessica-mitchell