Fix warnings regarding int-type variables #3026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terhorstd
added
S: Normal
heplesser
requested changes
Feb 5, 2024
JanVogelsang
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Looks good to me, as long as the changes by @heplesser get integrated.
|
@muffgaga , this seems to be basically complete except for the suggested change. Could you also add a description to this PR? The current sentence seems to have little relation to what your proposed change is. |
This commit fixes build-time warnings from the compiler that I encountered in my local build. It cleans up comparisons between unsigned size-like types (e.g. size_t) and signed indices (long/int).
Done, description also added to the commit (wasn't sure if adding text to the PR-opening comment is sufficient). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes build-time warnings from the compiler that I encountered in my local build.
It cleans up comparisons between unsigned size-like types (e.g.
size_t) and signed indices (long/int).Sorry for the close (of #3025)/reopen, github reacted weird when I pushed with full reference name
refs/heads/fix_warnings2…